Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor README and Implementation #16

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Refactor README and Implementation #16

merged 3 commits into from
Mar 8, 2021

Conversation

driusan
Copy link
Owner

@driusan driusan commented Mar 5, 2021

This refactors the README to be user-facing documentation rather than diving straight into the implementation, based on #15.

I also edited the Implementation.md (former README) for flow, since parts became hard to read when the implementation changed from using (rendered) markdown # headers to going into the (not visible while rendered) code block header after #3.

@driusan driusan mentioned this pull request Mar 5, 2021
Copy link
Contributor

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! You definitely improved on my gist. I left a couple of suggestions. If you wanted to credit me for the base tutorial, that would be very nice, but I won't be insulted if you don't.

@driusan
Copy link
Owner Author

driusan commented Mar 8, 2021

No problem.. how would you like to be credited? Should I find somewhere to work it into the text or create a separate authors/contributors.md file?

@dabrahams
Copy link
Contributor

Thanks; I'm happy to leave the details completely in your hands.

@driusan driusan merged commit a940ba5 into master Mar 8, 2021
@driusan
Copy link
Owner Author

driusan commented Mar 8, 2021

Okay, I added a credits section to the README.. seemed like the easiest way to give credit to everyone else who's contributed since it's not a verylong list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants