forked from lastmile-ai/aiconfig
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge STOP_STREAMING event into RUN_PROMPT_SUCCESS (lastmile-ai#928)
Merge STOP_STREAMING event into RUN_PROMPT_SUCCESS I just feel it makes a bit of sense to merge these two events together. I think this will be the final refacotring change I do I also: 1. Changed the `id` fields to `promptId` to be more explicit 2. Centralized logic for setting the ClientAIConfig into a `setRunningPromptId` function 3. Re-arranged the action cases in the aiconfigReducer switch to have the run actions together, as well as save success at the end ## Test Plan Everything still works as usual for streaming and non-streaming. Same video as the PRs earlier in this stack --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/928). * __->__ lastmile-ai#928 * lastmile-ai#926 * lastmile-ai#925 * lastmile-ai#924 * lastmile-ai#922 * lastmile-ai#921 * lastmile-ai#920 * lastmile-ai#919 * lastmile-ai#918 * lastmile-ai#917
- Loading branch information
Showing
3 changed files
with
153 additions
and
188 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.