Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fixed CI badge #937

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Documentation: fixed CI badge #937

merged 1 commit into from
Oct 4, 2024

Conversation

Alexander-Senko
Copy link
Collaborator

Before

Actions Status

After

Actions Status

y-yagi
y-yagi previously approved these changes Oct 4, 2024
Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated
@@ -1,6 +1,6 @@
# Draper: View Models for Rails

[![Actions Status](https://github.com/drapergem/draper/workflows/CI/badge.svg?branch=master)](https://github.com/drapergem/draper/actions?query=workflow%3Aci+branch%3Amaster)
[![Actions Status](https://github.com/drapergem/draper/actions/workflows/ci.yml/badge.svg?branch=master )](https://github.com/drapergem/draper/actions?query=workflow%3Aci+branch%3Amaster)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![Actions Status](https://github.com/drapergem/draper/actions/workflows/ci.yml/badge.svg?branch=master )](https://github.com/drapergem/draper/actions?query=workflow%3Aci+branch%3Amaster)
[![Actions Status](https://github.com/drapergem/draper/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/drapergem/draper/actions?query=workflow%3Aci+branch%3Amaster)

It seems that there is an unneeded space to the end.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y-yagi, you are really fast this time 😁 I noticed it too, but it took me some time to push the changes.

Copy link
Collaborator

@y-yagi y-yagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Alexander-Senko Alexander-Senko merged commit e9a5b36 into master Oct 4, 2024
9 checks passed
@Alexander-Senko Alexander-Senko deleted the fix/badges branch October 4, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants