Issue 7: Erroneous "?" (#8)

* return empty string if no query parameters are provided

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 4.0.1
+
+- **Bug Fix**
+  - Remove erroneous `?` from query string when no query string parameters are provided
+
 ## 4.0.0
 
 Because Dragonchain has a breaking change to replace its indexing solution, this is also a breaking SDK change for queries and custom indexing.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dragonchain-sdk",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "description": "Dragonchain SDK for Node.JS and the Browser",
   "license": "Apache-2.0",
   "homepage": "https://github.com/dragonchain/dragonchain-sdk-javascript#readme",

src/services/dragonchain-client/DragonchainClient.spec.ts

@@ -198,6 +198,11 @@ describe('DragonchainClient', () => {
         await client.getSmartContractLogs({ smartContractId: 'test', tail: 100, since: 'a-date' });
         assert.calledWith(fetch, `fakeUrl/v1/contract/test/logs?tail=100&since=a-date`, expectedFetchOptions);
       });
+
+      it('calls #fetch() with correct params and missing erroneous ?', async () => {
+        await client.getSmartContractLogs({ smartContractId: 'test' });
+        assert.calledWith(fetch, `fakeUrl/v1/contract/test/logs`, expectedFetchOptions);
+      });
     });
 
     describe('.getInterchainNetwork', () => {

src/services/dragonchain-client/DragonchainClient.ts

@@ -1347,7 +1347,7 @@ export class DragonchainClient {
   /**
    * @hidden
    */
-  private generateQueryString = (queryObject: Map<string, string | number>) => `?${UrlSearchParams(queryObject)}`;
+  private generateQueryString = (queryObject: Map<string, string | number>) => (Object.keys(queryObject).length > 0 ? `?${UrlSearchParams(queryObject)}` : '');
 
   /**
    * @hidden