Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tag SpecialKey #224

Closed
wants to merge 2 commits into from
Closed

Implement Tag SpecialKey #224

wants to merge 2 commits into from

Conversation

krypt102
Copy link
Contributor

@krypt102 krypt102 commented Feb 5, 2023

Fixes #36
This PR might be dependent on #216 due to xtypeof being removed, if necessary we can wait for that to be merged and then modify this code accordingly.

@dphfox dphfox added enhancement New feature or request not ready - design wanted Good idea but needs design work area: roblox labels Feb 6, 2023
@dphfox
Copy link
Owner

dphfox commented Feb 6, 2023

The issue was marked as 'needs design'. Please be wary of implementing features before a design is finalised.

In particular, we have not yet decided between [Tags] and [Tag "xxx"] styles. This PR is blocked until a style is decided upon - right now, it looks like we might be inclined to choose the latter over the former. Since this PR implements the former, it's likely you're going to have to redo your work, which is why we don't want pull requests for things that haven't been finalised - your time is as precious as ours, and we don't want to waste it.

@krypt102
Copy link
Contributor Author

krypt102 commented Feb 6, 2023

The issue was marked as 'needs design'. Please be wary of implementing features before a design is finalised.

That's my bad once again, the second time I've done this (idiot me), will be more aware of it next time I go to read.

I'll close this for now, and once we decide and it becomes approved I'll reopen!

@krypt102 krypt102 closed this Feb 6, 2023
@krypt102 krypt102 deleted the tags-specialkey branch February 6, 2023 06:39
@dphfox
Copy link
Owner

dphfox commented Feb 6, 2023

The issue was marked as 'needs design'. Please be wary of implementing features before a design is finalised.

That's my bad once again, the second time I've done this (idiot me), will be more aware of it next time I go to read.

I'll close this for now, and once we decide and it becomes approved I'll reopen!

Don't be too hard on yourself! It's okay to not know, as long as you keep it in mind for the future :)

@dphfox
Copy link
Owner

dphfox commented Aug 22, 2023

Issue is now approved, feel free to reopen

@krypt102 krypt102 restored the tags-specialkey branch September 3, 2023 07:01
@krypt102
Copy link
Contributor Author

krypt102 commented Sep 3, 2023

Reopened here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not ready - design wanted Good idea but needs design work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tag] for CollectionService tags
2 participants