Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety checks for applying properties #122

Closed
wants to merge 5 commits into from
Closed

Add safety checks for applying properties #122

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c1e5a2
Error mesages added
dphfox Jan 30, 2022
c91e575
Fix error formatting
dphfox Jan 30, 2022
bd0ce67
Update wording of errors
dphfox Jan 30, 2022
a21b0a1
Update duplicate key message to be general
dphfox Jan 30, 2022
4c03f63
Merge from main
dphfox Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Logging/messages.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
]]

return {
ambiguousParent = "The Parent of '%s' is ambiguous - only one Parent or [Children] is allowed at a time.",
applyPropsNilRef = "`applyInstanceProps` got a nil ref! (this is an internal issue)",
cannotAssignProperty = "The class type '%s' has no assignable property '%s'.",
cannotConnectChange = "The %s class doesn't have a property called '%s'.",
cannotConnectEvent = "The %s class doesn't have an event called '%s'.",
cannotCreateClass = "Can't create a new instance of class '%s'.",
computedCallbackError = "Computed callback error: ERROR_MESSAGE",
duplicatePropertyKey = "",
duplicatePropertyKey = "Can't assign to '%s' twice.",
invalidChangeHandler = "The change handler for the '%s' property must be a function.",
invalidEventHandler = "The handler for the '%s' event must be a function.",
invalidPropertyType = "'%s.%s' expected a '%s' type, but got a '%s' type.",
Expand Down