Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement instance hydration #120

Merged
merged 6 commits into from
Feb 4, 2022
Merged

Implement instance hydration #120

merged 6 commits into from
Feb 4, 2022

Conversation

dphfox
Copy link
Owner

@dphfox dphfox commented Jan 29, 2022

Implements #34, pretty simple code-wise.

Just need to write one or two unit tests for this and then it'll be golden!

@dphfox dphfox added the enhancement New feature or request label Jan 29, 2022
nottirb
nottirb reviewed Jan 29, 2022
View reviewed changes
Copy link
Contributor

@nottirb nottirb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As soon as you write unit testing I agree this should be golden.

@dphfox dphfox linked an issue Feb 3, 2022 that may be closed by this pull request
Binding to existing instances #34
Closed
@dphfox
Copy link
Owner Author

dphfox commented Feb 4, 2022

Unit tests passing all fine - mostly already covered by applyInstanceProps.spec.lua so only testing a couple bits here:

image

@dphfox dphfox marked this pull request as ready for review February 4, 2022 05:08
@dphfox dphfox merged commit ddf0fff into main Feb 4, 2022
@dphfox dphfox deleted the pr-820hydrate branch February 4, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nottirb nottirb nottirb left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binding to existing instances
2 participants
@dphfox @nottirb