useDefaultClean Option
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows default values to be set in the prototype which are taken into account when the plugin does not set such values.
If enabled, the default cleaner is used on the filename, which removes the first 3-5 characters if followed by an underscore or space symbol. For backward compatibility, the default cleaner is enabled by default. [#1558] Default cleaner considered harmful.
|
I cherry-picked all except for the localization fixes, adding a (IMO) better existence check on top of that. As for the localization fixes: The de locale changes seem OK, the en-US one is not. One topic per pull request, please ;) |
|
PS: Feel free to add you as a contributor. And feel free to add yourself as the "author": "poke" (or similar) to any new plugins you create. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo Nils,
hier ist der erste Pull-Request!
Ich hab eine neue Option
useDefaultCleanhinzugefügt, die es einzelnen Plugins erlaubt, den Standard-Cleaner zu deaktivieren. Beispielhaft dazu habe ich auch ein neues Plugin hinzugefügt, für Fotos auf Facebook. Dort ist es mir auch aufgefallen, dass der Standard-Cleaner nicht so optimal ist, weil die Facebook Dateinamen eh fürchterlich zufällig sind, es dort aber hilfreicher ist den gesamten Dateinamen zu erhalten, als manchmal die ersten Zeichen abzutrennen.Damit die Option richtig funktioniert und auch abwärtskompatibel ist, habe ich zuvor noch die Überschreibung der einzelnen Settings dynamisch gemacht. So kann man einzelne Optionen in dem Plugin-Prototype vorbelegen, die nur bei Angabe im Plugin selbst überschrieben werden.
Gruß
Patrick
In english
(didn't know pull request messages were public)
Hi Nils,
here is the first pull request!
I have added an option
useDefaultCleanto allow specific plugins to disable the default cleaner. I added a plugin for photos on facebook as an example. Initially I noticed the problem with the default cleaner there, as the filenames are completely random. Having the default cleaner randomly cut off the first characters for some files is not helpful then.To make that option work and backward compatible, I have also changed the way plugin settings are transferred in the factory. That way, we can preset particular plugin settings in the prototype and it will only get overwritten when the plugin sets that option itself.
Patrick