Fix equality test in vagrant-tramp-ssh

[kotfic]

This should resolve issues where a Vagrantfile generates multiple named
boxes.

[kotfic]

Also added (what i believe is) a fix for Issue #24

[kotfic]

@dougm PTAL thanks!

[ryanprior]

Hi @kotfic, I don't understand it. Maybe you can help?

The new awk program is:
{print $NF; NF--; gsub(/ /, "_", $0); print $0}

We print the total number of fields, which will always be one or two. So first we print, say, "2."

Then we decrement the number of fields, substitute underscores for spaces, and print the result, say "test vm"

The first print becomes $name, and the second becomes $dir_name. So in our example, $name="2" and $dir_name="test vm"

That doesn't seem right to me. Do I misunderstand how that awk code works?

[kotfic]

hi @ryanprior, print $NF actually prints the last field, not the number of fields (it is like running print $2 if there were only 2 fields), we then decrement the NF counter so the last field is not included, then join together all those fields with "_".

This means if you have a directory with underscores in the name (e.g. /path/to/some_folder) then the string passed to vagrant-tramp-ssh is some_folder_default and the tramp function tries to connect to folder_default which is incorrect. (note in the case of some_folder_default there are actually 3 fields).

[ryanprior]

@kotfic thank you for the explanation! The awk code I write tends to be very literal and that line went over my head. ;-D

I'm merging this change, even knowing that it may break somebody's configuration. I can't help but consider vagrant-tramp to be unstable until we land integration with vagrant machine-readable output and make a stable release.

See also: #8