Added icon animations to upvote and downvote icons for Doubts and Answers #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added animations for downvote as well to maintain parity. Demo - |
sidsharma2002
added a commit
that referenced
this pull request
Jun 29, 2023
* Implemented Filter Tags in the Main Home Screen * File Rename * Fixes * Addressed code review feedback * Review Changes * Removed onSearchClicked() function from fragments * Removed Unused code * fix fatal NPE for ViewDoubtViewModel (#73) * fix fatal NPE * logout user if user is null * code clean up * add non fatal log for null user * Added icon animations to upvote and downvote icons for Doubts and Answers (#68) * test * added animation to upvote and downvote icons for doubts * added animation to upvote and downvote icons for answers * fix animation for first load and code clean up * fix merge conflict --------- Co-authored-by: pratthamarora <[email protected]> * automatically close keyboard after search query is submitted (#70) * test * added animation to upvote and downvote icons for doubts * added animation to upvote and downvote icons for answers * fix animation for first load and code clean up * automatically close keyboard after search query is submitted * fix merge conflict --------- Co-authored-by: pratthamarora <[email protected]> * bottom nav icons changes * removed voting usecase from onBind * on pressing back on bottom nav redirects to home frag * in app notif implemented * Added Analytics in Filter Tags * Implemented Filter Tags in the Main Home Screen * File Rename * Fixes * Addressed code review feedback * Review Changes * Removed onSearchClicked() function from fragments * Removed Unused code * Added Analytics in Filter Tags * Fixed Merge Conflicts * fixed merge conflicts --------- Co-authored-by: Prattham Arora <[email protected]> Co-authored-by: pratthamarora <[email protected]> Co-authored-by: sidsharma2002 <[email protected]> Co-authored-by: Siddharth sharma <[email protected]>
KrishnaTech6
pushed a commit
to KrishnaTech6/doubtless-app
that referenced
this pull request
Jun 30, 2023
…wers (doubtless46#68) * test * added animation to upvote and downvote icons for doubts * added animation to upvote and downvote icons for answers * fix animation for first load and code clean up * fix merge conflict --------- Co-authored-by: pratthamarora <[email protected]>
KrishnaTech6
pushed a commit
to KrishnaTech6/doubtless-app
that referenced
this pull request
Jul 17, 2023
* Implemented Filter Tags in the Main Home Screen * File Rename * Fixes * Addressed code review feedback * Review Changes * Removed onSearchClicked() function from fragments * Removed Unused code * fix fatal NPE for ViewDoubtViewModel (doubtless46#73) * fix fatal NPE * logout user if user is null * code clean up * add non fatal log for null user * Added icon animations to upvote and downvote icons for Doubts and Answers (doubtless46#68) * test * added animation to upvote and downvote icons for doubts * added animation to upvote and downvote icons for answers * fix animation for first load and code clean up * fix merge conflict --------- Co-authored-by: pratthamarora <[email protected]> * automatically close keyboard after search query is submitted (doubtless46#70) * test * added animation to upvote and downvote icons for doubts * added animation to upvote and downvote icons for answers * fix animation for first load and code clean up * automatically close keyboard after search query is submitted * fix merge conflict --------- Co-authored-by: pratthamarora <[email protected]> * bottom nav icons changes * removed voting usecase from onBind * on pressing back on bottom nav redirects to home frag * in app notif implemented * Added Analytics in Filter Tags * Implemented Filter Tags in the Main Home Screen * File Rename * Fixes * Addressed code review feedback * Review Changes * Removed onSearchClicked() function from fragments * Removed Unused code * Added Analytics in Filter Tags * Fixed Merge Conflicts * fixed merge conflicts --------- Co-authored-by: Prattham Arora <[email protected]> Co-authored-by: pratthamarora <[email protected]> Co-authored-by: sidsharma2002 <[email protected]> Co-authored-by: Siddharth sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added icon animations to upvote and downvote icons for Doubts and Answers.
This PR addresses the issue #57