Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up relevant CA1416 warnings - Set 4 #26995

Merged

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Description of Change

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 8, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 8, 2025 10:01
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 8, 2025 10:01
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 8, 2025
@Tamilarasan-Paranthaman
Copy link
Contributor Author

@dotnet-policy-service terminate

@Tamilarasan-Paranthaman

This comment was marked as off-topic.

@jfversluis

This comment was marked as outdated.

This comment was marked as outdated.

@PureWeen PureWeen added this to the .NET 9 SR3 milestone Jan 8, 2025
@PureWeen

This comment was marked as outdated.

This comment was marked as outdated.

@PureWeen PureWeen requested a review from Copilot January 8, 2025 18:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Core/src/Handlers/Application/ApplicationHandler.iOS.cs:51

  • [nitpick] The comment should specify that ActivateSceneSession requires iOS 17+ or MacCatalyst 17+ for clarity.
// ActivateSceneSession requires 17+
@jfversluis jfversluis added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jan 9, 2025
@jsuarezruiz

This comment was marked as outdated.

This comment was marked as outdated.

@PureWeen PureWeen modified the milestones: .NET 9 SR3, .NET 9 SR4 Jan 14, 2025
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels almost done, just noticed that Apple has an api for all mac catalyst but only ios 17+

@PureWeen
Copy link
Member

PureWeen commented Jan 15, 2025

/azp run

This comment was marked as outdated.

@PureWeen PureWeen requested a review from mattleibow January 15, 2025 22:06
@mattleibow mattleibow enabled auto-merge (squash) January 17, 2025 14:14
@jfversluis

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the reenable_CA1416_part_4 branch from c5f7939 to c0ac7b6 Compare January 18, 2025 17:53
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Member

Failing tests are unrelated.

@jfversluis jfversluis disabled auto-merge January 20, 2025 12:57
@jfversluis jfversluis merged commit a46b6f7 into dotnet:main Jan 20, 2025
100 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants