-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add integration test stage to dnceng/public #26991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 2 comments.
Files not reviewed (7)
- src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/ToolRunner.cs: Evaluated as low risk
- eng/pipelines/common/variables.yml: Evaluated as low risk
- eng/pipelines/arcade/stage-unit-tests.yml: Evaluated as low risk
- eng/pipelines/arcade/stage-pack.yml: Evaluated as low risk
- src/TestUtils/src/Microsoft.Maui.IntegrationTests/AndroidTemplateTests.cs: Evaluated as low risk
- src/TestUtils/src/Microsoft.Maui.IntegrationTests/Android/Adb.cs: Evaluated as low risk
- src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/TestEnvironment.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)
eng/pipelines/common/setup-android-dependencies.yml:12
- [nitpick] The temporary project directory name 'TempDroid' is not very descriptive. Consider renaming it to something more descriptive like 'TemporaryAndroidProject'.
arguments: android -o $(Agent.TempDirectory)/TempDroid
src/TestUtils/src/Microsoft.Maui.IntegrationTests/Android/Emulator.cs:21
- The new AcceptLicenses method should be covered by tests to ensure it works as expected.
public bool AcceptLicenses(out string acceptLicenseOutput)
src/TestUtils/src/Microsoft.Maui.IntegrationTests/Android/Emulator.cs:39
- The increased timeout for InstallAvd should be covered by tests to ensure it does not cause unintended side effects.
installOutput = ToolRunner.Run(SdkManagerTool, $"\"{SystemImageId}\"", out int exitCode, timeoutInSeconds: 180);
@@ -11,14 +13,24 @@ steps: | |||
|
|||
- template: /eng/pipelines/common/setup-jdk.yml | |||
|
|||
- script: | | |||
sudo xcode-select -s /Applications/Xcode_$(REQUIRED_XCODE).app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line introduces a potential breaking change if REQUIRED_XCODE
is not defined or if the specified Xcode version is not available. Ensure that REQUIRED_XCODE
is properly defined and the specified Xcode version is available on the build agents.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
An Integration test stage has been added to the dnceng/public build.
This should be the last piece needed to mirror the existing MAUI public
PR build in xamarin/public.
Some adjustments have been made to the Android emulator creation and
launch process to improve the performance on the default hosted macOS
images. A SDK license acceptance workflow has also been added to fix
AVD installation in certain cases.