Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RGen] Generate getter methods for propertes with NSValue BindFrom attrs. #22353

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[RGen] Generate getter methods for propertes with NSValue BindFrom attrs. #22353

wants to merge 6 commits into from
+519 −20

Conversation

mandel-macaque
Copy link
Member

Generate the code for those properties that have getters that have been decorated with a BindFromAttribute taking a NSValue.

The change generates code for both the single and array cases.

mandel-macaque and others added 6 commits March 10, 2025 12:12
@mandel-macaque
[RGen] Add support to generate the BindFrom getter calls.
e100d13 
Generate the needed code for the properties that have a BindFrom
attribute with a NSNumber.

The code supports both arrays and single NSValue variables.
Auto-format source code
9b11de5
@mandel-macaque @rolfbjarne
Update src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFact…
560e473 
…ory.Runtime.cs

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
@mandel-macaque
Merge branch 'main' into dev/mandel/rgen-nsnumber-bindfrom-getter
67c2520
@mandel-macaque
[RGen] Generate getter methods for propertes with NSValue BindFrom at…
16bf59e 
…trs.

Generate the code for those properties that have getters that have been
decorated with a BindFromAttribute taking a NSValue.

The change generates code for both the single and array cases.
Auto-format source code
6096323
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #6096323] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6096323] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6096323] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6096323] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6096323] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6096323] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6096323] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6096323] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

Base automatically changed from dev/mandel/rgen-nsnumber-bindfrom-getter to main March 11, 2025 00:30
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #6096323] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 113 tests passed.

Failures

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 60963239240c3e4a15ab1eaa1d68443e6816325e [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandel-macaque @vs-mobiletools-engineering-service2