[RGen] Return the correct NSNumber static method when we have an array. #22342
Conversation
Array types a special because we have to track the array element type rathern that the actual SpecialType of the array (which is SpecialType.None). We add a new property to our data model to track the special type of the element and we create a helper tuple to keep the switch expression clean. This could have been done without the helper tuple, but the code look a lot worse, the compiler is smart enough to remove that extra tuple.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #4046fc5] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #4046fc5] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #4046fc5] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #4046fc5] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #4046fc5] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #4046fc5] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
|
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash 40c2efb. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #4046fc5] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
❌ [CI Build #a3b5e56] Tests on macOS arm64 - Mac Sequoia (15) failed ❌Failed tests are:
Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #a3b5e56] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 111 tests passed. Failures❌ introspection tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Array types a special because we have to track the array element type rathern that the actual SpecialType of the array (which is SpecialType.None).
We add a new property to our data model to track the special type of the element and we create a helper tuple to keep the switch expression clean. This could have been done without the helper tuple, but the code look a lot worse, the compiler is smart enough to remove that extra tuple.