Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rgen] Update transformers to take the binding struct in the message. #22327

Merged
merged 4 commits into from
Mar 10, 2025
Merged

[Rgen] Update transformers to take the binding struct in the message. #22327

merged 4 commits into from
Mar 10, 2025

Conversation

mandel-macaque
Copy link
Member

Now that we have the binding struct we can update the workers to get it and use its data to perform the needed transformation.

mandel-macaque and others added 3 commits March 6, 2025 17:39
@mandel-macaque
[Rgen] Start creating the binding struct for the transformations.
48b4d88 
Add support to use the data model in the transformer. What we do know
is:

1. Create a biding struct based on the compilation and the semantic
   model.
2. Select the topic based on the binding data.

We are not yet sending the biding data to the transformer or taking into
consideration that we need to deal with more than one platform yet.
@mandel-macaque
[Rgen] Update transformers to take the binding struct in the message.
bec2c3d 
Now that we have the binding struct we can update the workers to get it
and use its data to perform the needed transformation.
Auto-format source code
da57c76
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
Base automatically changed from dev/mandel/transformer-create-binding-for-symbol to main March 7, 2025 22:45
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #67530e4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #67530e4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #67530e4] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #67530e4] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 116 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #67530e4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #67530e4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #67530e4] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

@mandel-macaque mandel-macaque merged commit e5fc10d into main Mar 10, 2025
45 of 47 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/transformer-update-workers branch March 10, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @StephaneDelcroix