[Bgen] Improve the generated code for SmarEnum BindAs calls. #22323

mandel-macaque · 2025-03-06T17:55:29Z

Because we now have a GetValue method that takes a NativeHandle, we can simplify the code generated when we are dealing with a smart enum in a BindAs decorated property/method.

The old generated code is:

ret = global::CoreAnimation.CACornerCurveExtensions.GetValue (Runtime.GetNSObject<NSString> (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSend (this.Handle, Selector.GetHandle ("cornerCurve")), false)!);

While the new one is:

ret = global::NaturalLanguage.NLLanguageExtensions.GetValue (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSendSuper (this.SuperHandle, Selector.GetHandle ("language")));

The code is simpler, but there is also a small memory imrpovement. In the old version of the binding, we were not callin the Dispose method in the NSString. On the other hand, the new code uses the GetValue method that is disposing the NSString as soon as it leaves the method and therefore it does not need the GC to take care of it.

PS: There is no need to change the code that creates the wrapper because we are using method overloading.

Because we now have a GetValue method that takes a NativeHandle, we can simplify the code generated when we are dealing with a smart enum in a BindAs decorated property/method. The old generated code is: ```csharp ret = global::CoreAnimation.CACornerCurveExtensions.GetValue (Runtime.GetNSObject<NSString> (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSend (this.Handle, Selector.GetHandle ("cornerCurve")), false)!); ``` While the new one is: ```csharp ret = global::NaturalLanguage.NLLanguageExtensions.GetValue (global::ObjCRuntime.Messaging.NativeHandle_objc_msgSendSuper (this.SuperHandle, Selector.GetHandle ("language"))); ``` The code is simpler, but there is also a small memory imrpovement. In the old version of the binding, we were not callin the Dispose method in the NSString. On the other hand, the new code uses the GetValue method that is disposing the NSString as soon as it leaves the method and therefore it does not need the GC to take care of it.

github-actions · 2025-03-06T17:59:29Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2025-03-09T23:34:45Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-03-09T23:56:09Z

✅ [CI Build #ceede5d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T23:57:43Z

✅ [PR Build #ceede5d] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:05:25Z

✅ [CI Build #ceede5d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:18:07Z

💻 [CI Build #ceede5d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:19:21Z

💻 [CI Build #ceede5d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:20:35Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:20:58Z

💻 [CI Build #ceede5d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:35:10Z

❌ [CI Build #ceede5d] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:35:11Z

❌ [CI Build #65b637e] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 65b637e556a2dee32b3673bc44be52567c137c8d [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T01:45:02Z

❌ [CI Build #ceede5d] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T02:30:42Z

🔥 [CI Build #ceede5d] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ generator tests

1 tests failed, 4 tests passed.

BGen tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ceede5db89fde29099c641e583b5b83866724018 [PR build]

mandel-macaque and others added 2 commits March 6, 2025 12:49

Auto-format source code

78eefef

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Mar 7, 2025

View reviewed changes

dalexsoto approved these changes Mar 7, 2025

View reviewed changes

mandel-macaque and others added 3 commits March 9, 2025 12:59

Merge branch 'main' into dev/mandel/get-value-handle-nullable

b378441

Fix code to take into account those methods that return a nullable enum.

65b637e

Auto-format source code

ceede5d

This comment has been minimized.

Sign in to view

[Bgen] Improve the generated code for SmarEnum BindAs calls. #22323

Are you sure you want to change the base?

[Bgen] Improve the generated code for SmarEnum BindAs calls. #22323

Conversation

mandel-macaque commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Mar 9, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ [CI Build #ceede5d] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ [PR Build #ceede5d] Build passed (Detect API changes) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 10, 2025

✅ [CI Build #ceede5d] Build passed (Build macOS tests) ✅

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 10, 2025

💻 [CI Build #ceede5d] Tests on macOS M1 - Mac Monterey (12) passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 10, 2025

💻 [CI Build #ceede5d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Mar 10, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Mar 10, 2025

💻 [CI Build #ceede5d] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Mar 10, 2025

❌ [CI Build #ceede5d] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Mar 10, 2025

❌ [CI Build #65b637e] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Mar 10, 2025

❌ [CI Build #ceede5d] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 10, 2025

🔥 [CI Build #ceede5d] Test results 🔥

Test results

Failures

❌ generator tests

Successes