Add .NET 10 Dockerfiles #6161
Add .NET 10 Dockerfiles #6161
Conversation
|
Oh, the failing tests are ASP.NET Composite Runtime only. This is ASP.NET Composite runtime and non-composite .NET runtime versions are out of sync for some preview versions (#4834). It's not great, but I think we should disable those tests for now. |
| set isPowerShellSupported to !(isAlpine && ARCH_SHORT != "x64") ^ | ||
| set includePowerShellVars to isPowerShellSupported || dotnetVersion = "8.0" || dotnetVersion = "9.0" ^ |
There was a problem hiding this comment.
To me, it seems there should just be one variable. There's no point in defining variables if powershell is not being installed.
There was a problem hiding this comment.
The reason includePowerShellVars is separate is to prevent Dockerfile changes for .NET versions < 10.
Today, we include PS telemetry variables even in SDK images where we don't ship PowerShell:
dotnet-docker/src/sdk/9.0/alpine3.20/arm32v7/Dockerfile
Lines 17 to 18 in ccbb4f2
I noticed this and fixed it for .NET 10+ only because removing it could be considered a breaking change.
There was a problem hiding this comment.
Are there any differences in these 10.0 runtime-deps Dockerfiles compared to 9.0? If not, then we should share the Dockerfiles from 9.0.
See #6070
This PR is a work in progress.