Update diagnostic ID CP0012 description #44889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
approved these changes
Feb 13, 2025
Co-authored-by: Genevieve Warren <[email protected]>
|
Let me first merge my sdk PR. |
ericstj
reviewed
Feb 13, 2025
ericstj
approved these changes
Feb 13, 2025
ViktorHofer
approved these changes
Feb 13, 2025
Co-authored-by: Genevieve Warren <[email protected]>
|
The sdk PR has been merged: dotnet/sdk#46797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are making a small code change in the functionality of this diagnostic ID in a way that now the removal of either the virtual or the abstract keywords will trigger the same diagnostic ID.
Here is the PR that will change that functionality: dotnet/sdk#46797
Internal previews