-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nameof
for open generic types, first class span implicit conversions, and implicit lambda parameters with modifiers
#44641
Open
BillWagner
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
BillWagner:unbound-nameof
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's hold this until the first .NET 10 preview comes out. That will fix the snippets 5000 build, and the new example will compile. |
9c7d77f
to
b519187
Compare
nameof
and open generic typesnameof
and open generic types, and first class span implicit conversions
a3857be
to
2556e03
Compare
@CamSoper This is ready for review. The snippets build will pass once .NET 10 preview 1 is public. I'd like to merge it once that's available. |
gewarren
approved these changes
Feb 6, 2025
BillWagner
commented
Feb 6, 2025
b5ff933
to
4f0d3d1
Compare
CamSoper
approved these changes
Feb 12, 2025
4f0d3d1
to
854ccdc
Compare
nameof
and open generic types, and first class span implicit conversionsnameof
for open generic types, first class span implicit conversions, and implicit lambda parameters with modifiers
BillWagner
commented
Feb 14, 2025
8130daf
to
7d1c6a6
Compare
Fixes dotnet#44182 Add that `nameof` now supports open generic types. This is the first C# 14 feature I've added, so create the C# 14 file, and update the language version tables accordingly.
Get this ready for the first preview
Add updates to C# 14 for the First class Span types.
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Fixes dotnet#44887 Publish the speclet and update the language reference to allow modifiers on implicitly typed lambda expressions.
Co-authored-by: Kathleen Dollard <[email protected]>
7d1c6a6
to
c42223b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameof
supports unbound generic types #44182: Add thatnameof
now supports open generic types.This is the first C# 14 feature I've added, so create the C# 14 file, and update the language version tables accordingly.
Many of the files that have been updated are updating links and anchors. Major changes are:
=>
) operator defines a lambda expressionis
,as
,typeof
, and castsInternal previews
Toggle expand/collapse
params
modifier on method parameters=>
) operator defines a lambda expressionis
,as
,typeof
, and caststypeof
tonameof
(IDE0082)Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.