Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default dependency on Docker CLI for generating Dockerfiles #1508

Merged
merged 7 commits into from
Dec 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add new options interfaces for new filters
lbussell committed Nov 27, 2024
commit 19398443898ff2291c38e6e2223346e56ad976a3
Original file line number Diff line number Diff line change
@@ -8,4 +8,14 @@ public interface IFilterableOptions
{
ManifestFilterOptions FilterOptions { get; }
}

public interface IPlatformFilterableOptions
{
PlatformFilterOptions Platform { get; }
}

public interface IDockerfileFilterableOptions
{
DockerfileFilterOptions Dockerfile { get; }
}
}
Original file line number Diff line number Diff line change
@@ -27,14 +27,35 @@ public virtual ManifestFilter GetManifestFilter()

if (this is IFilterableOptions options)
{
ManifestFilterOptions filterOptions = options.FilterOptions;
filter.IncludeArchitecture = filterOptions.Platform.Architecture;
filter.IncludeOsType = filterOptions.Platform.OsType;
filter.IncludeOsVersions = filterOptions.Platform.OsVersions;
filter.IncludePaths = filterOptions.Dockerfile.Paths;
filter.IncludeProductVersions = filterOptions.Dockerfile.ProductVersions;
filter = SetPlatformFilters(filter, options.FilterOptions.Platform);
filter = SetDockerfileFilters(filter, options.FilterOptions.Dockerfile);
}

if (this is IPlatformFilterableOptions platformFilterOptions)
{
filter = SetPlatformFilters(filter, platformFilterOptions.Platform);
}

if (this is IDockerfileFilterableOptions dockerfileFilterOptions)
{
filter = SetDockerfileFilters(filter, dockerfileFilterOptions.Dockerfile);
}

return filter;
}

private static ManifestFilter SetDockerfileFilters(ManifestFilter filter, DockerfileFilterOptions options)
{
filter.IncludePaths = options.Paths;
filter.IncludeProductVersions = options.ProductVersions;
return filter;
}

private static ManifestFilter SetPlatformFilters(ManifestFilter filter, PlatformFilterOptions options)
{
filter.IncludeArchitecture = options.Architecture;
filter.IncludeOsType = options.OsType;
filter.IncludeOsVersions = options.OsVersions;
return filter;
}
}