Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use provided references for search of dependencies in AssemblyCompilations #10491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Herrmel
Copy link

@Herrmel Herrmel commented Jan 2, 2025

Use provided references for search of dependencies in AssemblyCompilations.

This should resolve my issue in #10423.

Since I did not get any feedback on how best resolve the issue I thought maybe this would get some attention. What this approach does is basicly use the provided Metadatareferences and use their filepaths (if present) to help resolve dependencies via filenames for those that are not found by default.

I also included a small code duplication cleanup, I hope thats also ok.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.33%. Comparing base (fe673ec) to head (7e94ee7).
Report is 502 commits behind head on main.

Files with missing lines Patch % Lines
src/Docfx.Dotnet/CompilationHelper.cs 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10491      +/-   ##
==========================================
+ Coverage   74.31%   79.33%   +5.01%     
==========================================
  Files         536      547      +11     
  Lines       23189    23634     +445     
  Branches     4056     4066      +10     
==========================================
+ Hits        17234    18751    +1517     
+ Misses       4853     3711    -1142     
- Partials     1102     1172      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants