You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, the @nestjs/graphql module shares a similar API interface with type-graphql. However, I encountered a scenario where I required the usage of nestjs graphql instead of type-graphql. To accommodate this, I introduced a configuration flag to switch from using type-graphql to @nestjs/graphql. All tests have successfully passed without the inclusion of a new plugin for @nestjs/graphql.given that the @nestjs/graphql implementation heavily relies on the type-graphql library, effectively behaving as a subtype of that library.
no dependency needed to be added
Type of change
New feature (non-breaking change which adds functionality)
This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
type-graphql.spec
Test Environment:
OS: Mac OS
@graphql-codegen/typescript-type-graphql.:
NodeJS: 20
Checklist:
I have followed the CONTRIBUTING doc and the
style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@bridges-wood
Great 😃 but I believe if we had a discussion about it we would go to this result too as i see now it's just copy paste from typegraphql implementation i though to go with the current approach but it seems a duplication as it now so I added this flag but overall thanks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presently, the @nestjs/graphql module shares a similar API interface with type-graphql. However, I encountered a scenario where I required the usage of nestjs graphql instead of type-graphql. To accommodate this, I introduced a configuration flag to switch from using type-graphql to @nestjs/graphql. All tests have successfully passed without the inclusion of a new plugin for @nestjs/graphql.given that the @nestjs/graphql implementation heavily relies on the type-graphql library, effectively behaving as a subtype of that library.
no dependency needed to be added
Type of change
New feature (non-breaking change which adds functionality)
This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-codegen/typescript-type-graphql.:Checklist:
CONTRIBUTING doc and the
style guidelines of this project