Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate pages for research content (Fixes #426) #432

Merged
merged 18 commits into from
Oct 20, 2023
Merged

separate pages for research content (Fixes #426) #432

merged 18 commits into from
Oct 20, 2023

Conversation

davidstanke
Copy link
Collaborator

@davidstanke davidstanke commented Oct 13, 2023 •
edited
Loading

This PR

  • Replaces the javascript tab navigation on /research pages with actual separate pages
  • Introduces a new tab partial (which relies on tab_order and tab_title front matter params)
  • Adds content to the research sub-pages for research/2023, research/2022, research/2021, and research/2019
  • Adds SEMs for 2023
  • Adds redirect rules for legacy tab_archive urls

Preview at:
https://doradotdev-staging--pr432-lirjkjf9.web.app/research/2023
https://doradotdev-staging--pr432-lirjkjf9.web.app/research/2022
https://doradotdev-staging--pr432-lirjkjf9.web.app/research/2021
https://doradotdev-staging--pr432-lirjkjf9.web.app/research/2019

Fixes #426

@dora-machine-user
Copy link
Collaborator

dora-machine-user commented Oct 13, 2023 •
edited
Loading

Cloud Build time: Fri Oct 20 20:41:57 UTC 2023
Preview this PR [including DRAFT content] at https://doradotdev-staging--pr432-draft-36f1dc31.web.app
Preview this PR [published content only] at https://doradotdev-staging--pr432-lirjkjf9.web.app

@davidstanke davidstanke added the do not merge This change is not yet ready for merging label Oct 13, 2023
@davidstanke davidstanke removed the do not merge This change is not yet ready for merging label Oct 20, 2023
@davidstanke davidstanke marked this pull request as ready for review October 20, 2023 19:18
@davidstanke davidstanke changed the title [WIP] separate pages for research content (Fixes #426) separate pages for research content (Fixes #426) Oct 20, 2023
nathenharvey
nathenharvey requested changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@nathenharvey nathenharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments/ suggestions.

There's also something off about the font in the url at the bottom of the 2023 infographic (hugo/content/research/2023/dora-report/2023-dora-report-infographic.svg)

@davidstanke davidstanke merged commit 1096779 into main Oct 20, 2023
@davidstanke davidstanke deleted the 426-Split-research-archive-tabs-into-separate-pages-2023 branch October 20, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathenharvey nathenharvey nathenharvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split research archive tabs into separate pages: 2023
3 participants
@davidstanke @dora-machine-user @nathenharvey