Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This may be sth. for Archaic as well #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sevu
Copy link

@sevu sevu commented Jan 17, 2017

In debug mode it's possible to play SP campaigns in multiplayer.
In multiplayer, units are shared among add-ons, and the campaign reads them a 2nd time.
Wesnoth will tell on stderr then that it knows now multiple units with the same ID.

@sevu
Copy link
Author

sevu commented Jan 17, 2017

About the 2nd comment line, this is targeted to other people who might read your code.
There is no such case in the era or the campaigns. I was thinking about the lvl 4 fire elemental in War of Legends with the extra_defines, or possible new campaign writers who may want to use an advancefrom.

@doofus-01
Copy link
Owner

I recall seeing that SP campaigns could be played MP in debug, and being kind of annoyed. I still don't see the reason for that feature, but this PR looks harmless enough. Give me a few days, I'll have time to do something.
Thanks.

@sevu
Copy link
Author

sevu commented Jan 18, 2017

Sure, you're welcome.
I don't know what the intention was either. Maybe this is the way to play SP campaigns with enabling MP modifications.
This PR just makes the situation a little bit better, if somebody does that.
Though, I think it's not worthy to support the MP way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants