[DOM-62849] Add S3 Private endpoint Interface #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-dclegg
reviewed
Feb 13, 2025
Secretions
requested changes
Feb 14, 2025
ddl-dclegg
reviewed
Feb 18, 2025
| @@ -53,6 +56,9 @@ variable "network_info" { | |||
| ecr_endpoint = optional(object({ | |||
| security_group_id = optional(string, null) | |||
| }), null) | |||
| s3_endpoint = optional(object({ | |||
There was a problem hiding this comment.
This isn't a big deal at all, but this is one place we use endpoint and in other places it's interface. It may make sense to unify on one term in some future update.
ddl-dclegg
reviewed
Feb 18, 2025
There was a problem hiding this comment.
Still looks good to me, will hold my 👍 for @Secretions to determine if his concerns are resolved.
Secretions
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per documentation and confirmed by our experimentation as well, our current setup for S3 connectivity is not ‘full privatelink’ (whatever that really means to AWS).
While connectivity is still secure and does not leave the AWS network infrastructure, to be fully 'privatelink' compliant (as to what our customers may expect from that) we are missing to deploy an interface endpoint with private DNS enabled on each deployment.