PLAT-9123: Costs module non-kms mode #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4460b9c. If you want this encrypted, you can just turn on kms. This keeps parity with Ashok's customer, and makes the options more literally honest.
ddl-dclegg
approved these changes
Feb 7, 2025
ddl-dclegg
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The costs terraform submodule, with cost reporting on, does not currently work when KMS is disabled.
This fixes that so what can use SSE uses SSE, and what can't is simply not encrypted. If you have an issue with the lack of encryption for those things, you should enable KMS, as those two things simply do not support encryption any other way.