Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM-65441: Loosen frozendict restrictions to allow version 2.4.6 #212

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ddl-ignacio-rossi
Copy link
Contributor

@ddl-ignacio-rossi ddl-ignacio-rossi commented Feb 11, 2025

Link to JIRA

DOM-65441

What issue does this pull request solve?

The frozendict restriction in the package is too strict and conflicts with 2.4.6 which conda requires to work properly.
This should also take care of #211

What is the solution?

This PR loosens the restriction from ~=2.3.8 (equivalent to >=2.3.8,<2.4) to ~=2.3 (equivalent to >=2.3,<3). See https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release for details

Testing

I tested that installing the requirements file will install the latest 2.x frozendict

  • Unit test(s)

Pull Request Reminders

References (optional)

@ddl-ignacio-rossi ddl-ignacio-rossi marked this pull request as ready for review February 11, 2025 13:11
@ddl-ignacio-rossi ddl-ignacio-rossi requested a review from a team as a code owner February 11, 2025 13:12
@ddl-ignacio-rossi ddl-ignacio-rossi merged commit e47c7b0 into master Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants