Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the get datasource issue with no run id (#147) #150

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ddl-joyce-zhao
Copy link
Contributor

@ddl-joyce-zhao ddl-joyce-zhao commented Nov 4, 2024

Description

Port the fix of domino run id from 5.11 to the main branch

Fix the wrong default domino run id when getting the data source.

Related Issue

https://dominodatalab.atlassian.net/browse/DOM-57725
https://dominodatalab.atlassian.net/browse/DOM-62827

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

* fixed the get run id issue

* Reverted unnecessary change

* Update pyproject.toml
Copy link

github-actions bot commented Nov 4, 2024

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.15-final-0 ----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 43 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 101 14 86%
domino_data/configuration_gen.py 232 0 100%
domino_data/data_sources.py 291 24 92%
domino_data/logging.py 10 0 100%
domino_data/meta.py 22 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 135 10 93%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
domino_data/vectordb.py 23 4 83%
TOTAL 1116 83 93%

~ 67 passed in 15.07s ~

@ddl-joyce-zhao ddl-joyce-zhao requested review from a team and ddl-eric-jin November 4, 2024 22:10
Copy link
Collaborator

@ddl-eric-jin ddl-eric-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ddl-joyce-zhao ddl-joyce-zhao merged commit b59b1f0 into main Nov 5, 2024
7 checks passed
@ddl-joyce-zhao ddl-joyce-zhao deleted the ddl-joyce-zhao.DOM-62827.fix-run-id branch November 5, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants