Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen pinecone version #146

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ mypy:
.PHONY: check-safety
check-safety:
poetry check
# TODO remove numpy ignore flag when fixed
poetry run safety check --full-report -i 44715 -i 51668
# TODO remove pip ignore flag when fixed
poetry run safety check --full-report -i 62044 -i 67599
poetry run bandit -ll --recursive domino_data tests

.PHONY: lint
Expand Down
4 changes: 2 additions & 2 deletions domino_data/vectordb.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def get_host_from_settings(self, index, variables=None, servers=None):


def domino_pinecone3x_init_params(datasource_name: str) -> Dict[str, Union[str, Dict[str, str]]]:
"""Wrap the parameters to initialize a Pinecone 3.x client
"""Wrap the parameters to initialize a Pinecone 3.x and above client

Args:
datasource_name: the name of the Pinecone data source
Expand All @@ -82,7 +82,7 @@ def domino_pinecone3x_init_params(datasource_name: str) -> Dict[str, Union[str,
def domino_pinecone3x_index_params(
datasource_name: str, index_name: str
) -> Dict[str, Union[str, Dict[str, str]]]:
"""Wrap the parameters to target an index in the Pinecone 3.x client
"""Wrap the parameters to target an index in the Pinecone 3.x and above client

Args:
datasource_name: the name of the Pinecone data source
Expand Down
Loading
Loading