Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-52834] Update Submodule #130

Closed

Conversation

ddl-eric-jin
Copy link
Collaborator

Description

Update submodule based on version with subfolder field for S3 / Generic S3 with oAuth.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ddl-eric-jin ddl-eric-jin requested a review from a team January 18, 2024 07:29
@ddl-eric-jin ddl-eric-jin self-assigned this Jan 18, 2024
Copy link

github-actions bot commented Jan 18, 2024

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.18-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 90 13 86%
domino_data/configuration_gen.py 227 0 100%
domino_data/data_sources.py 290 24 92%
domino_data/logging.py 10 0 100%
domino_data/meta.py 22 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
domino_data/vectordb.py 16 4 75%
TOTAL 1081 82 92%

~ 65 passed in 14.49s ~

@ddl-joyce-zhao
Copy link
Contributor

included in #132

@ddl-eric-jin
Copy link
Collaborator Author

Closing since the updated submodule is included in another PR.

@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-52834.update-data-services branch January 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants