Skip to content

Commit

Permalink
Fixed the test failure
Browse files Browse the repository at this point in the history
  • Loading branch information
ddl-joyce-zhao committed Apr 1, 2024
1 parent b674c41 commit 3a78c59
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 20 deletions.
6 changes: 3 additions & 3 deletions domino_data/vectordb.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Dict
from typing import Dict, Union

import os

Expand Down Expand Up @@ -63,7 +63,7 @@ def get_host_from_settings(self, index, variables=None, servers=None):
return url.replace("https://", "http://")


def domino_pinecone3x_init_params(datasource_name: str) -> Dict[str, str]:
def domino_pinecone3x_init_params(datasource_name: str) -> Dict[str, Union[str, Dict[str, str]]]:
"""Wrap the parameters to initialize a Pinecone 3.x client
Args:
Expand All @@ -79,7 +79,7 @@ def domino_pinecone3x_init_params(datasource_name: str) -> Dict[str, str]:
}


def domino_pinecone3x_index_params(datasource_name: str, index_name: str) -> Dict[str, str]:
def domino_pinecone3x_index_params(datasource_name: str, index_name: str) -> Dict[str, Union[str, Dict[str, str]]]:
"""Wrap the parameters to target an index in the Pinecone 3.x client
Args:
Expand Down
55 changes: 39 additions & 16 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ feast = "^0.35.0"
GitPython = "^3.1.41"

[tool.poetry.group.vectordbs.dependencies]
pinecone-client = ">=2.2.4"
pinecone-client = "^2.2.4"

[tool.black]
# https://github.com/psf/black
Expand Down

0 comments on commit 3a78c59

Please sign in to comment.