Skip to content

Commit

Permalink
Pass in nameservers and timeout when running get_dnskey recursi…
Browse files Browse the repository at this point in the history
…vely
  • Loading branch information
seanthegeek committed Jan 7, 2024
1 parent 96be08c commit 7fb98c8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Changelog
- Do not require an `RRSIG` answer when querying for `DNSKEY` records
- On Windows and macOS, querying for a `DNSKEY` record on `proton.ch` will return a `RRSET` and `RRSIG`. However,
running the same query on Debian-based Linux will only return a `RRSET`
- Pass in `nameservers` and `timeout` when running `get_dnskey` recursively

5.2.6
-----
Expand Down
4 changes: 3 additions & 1 deletion checkdmarc/dnssec.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def get_dnskey(domain: str, nameservers: list[str] = None,
logging.debug(f"No DNSKEY records found at {domain}")
base_domain = get_base_domain(domain)
if domain != base_domain:
return get_dnskey(base_domain)
return get_dnskey(base_domain,
nameservers=nameservers,
timeout=timeout)
cache[domain] = None
return None
rrset = answer[0]
Expand Down

0 comments on commit 7fb98c8

Please sign in to comment.