-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utils function for snowflake worker and process ids, with increment #770
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. The additions to utils.py are fine (though please add the new functions to __all__
), but I feel like the addition of properties to nearly every object is just unnecessary pollution, especially as this information is not very useful most of the time.
I've removed the properties I made to the previous objects and kept only the functions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply to the other two as well
Co-authored-by: dolfies <[email protected]>
Co-authored-by: dolfies <[email protected]>
Co-authored-by: dolfies <[email protected]>
Summary
Adds the worker and process IDs from snowflakes as attributes for I think most of the objects that support it. Alongside the increment.
General Info