Skip to content

Commit

Permalink
button focusable even if it wasnt shown fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@franklin-amaya
franklin-amaya committed Dec 26, 2023
1 parent d5e5aee commit 37e2d99
Show file tree
Hide file tree
Showing 2 changed files with 165 additions and 163 deletions.
274 changes: 137 additions & 137 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,139 +1,139 @@
{
"name": "@dod-advana/advana-platform-ui",
"version": "2.8.4",
"private": false,
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/dod-advana/advana-module-platform-ui.git"
},
"babel": {
"presets": [
"@babel/preset-react",
"@babel/preset-env"
],
"plugins": [
[
"@babel/plugin-proposal-class-properties",
{
"loose": true
}
],
[
"@babel/plugin-syntax-class-properties"
],
[
"@babel/plugin-proposal-private-methods",
{
"loose": true
}
],
[
"babel-plugin-import",
{
"libraryName": "@material-ui/core",
"libraryDirectory": "",
"camel2DashComponentName": false
},
"core"
],
[
"babel-plugin-import",
{
"libraryName": "@material-ui/icons",
"libraryDirectory": "",
"camel2DashComponentName": false
},
"icons"
]
]
},
"dependencies": {
"@babel/plugin-proposal-class-properties": "7.13.0",
"@babel/plugin-syntax-class-properties": "7.12.13",
"@datapunt/matomo-tracker-react": "0.4.0",
"@emotion/react": "11.9.3",
"@emotion/styled": "11.9.3",
"@material-ui/core": "4.11.4",
"@material-ui/icons": "4.11.2",
"axios": "1.4.0",
"babel-plugin-import": "1.13.5",
"jws": "4.0.0",
"react-slidedown": "2.4.5",
"styled-components": "5.2.3",
"underscore": "1.13.1"
},
"peerDependencies": {
"react": "17.0.2",
"react-dom": "17.0.2",
"react-router-dom": "6.10.0"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "jest --coverage --coverageDirectory=test/coverage --detectOpenHandles --passWithNoTests",
"publish:local": "npm publish --registry http://localhost:4873/",
"publish:aws": "npm publish --registry http://10.194.9.122",
"publish:prepare": "rm -rf dist && mkdir dist && babel src/lib -d dist --copy-files",
"sonarscan": "sonar-scanner"
},
"resolutions": {
"@babel/preset-env": "7.16.4",
"ansi-html": "0.0.9",
"browserslist": "4.17.3",
"glob-parent": "5.1.2",
"immer": "9.0.6",
"node-forge": "1.0.0",
"nth-check": "2.0.1",
"shell-quote": "1.7.3"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"@babel/cli": "7.13.16",
"@babel/plugin-proposal-private-methods": "7.16.11",
"@babel/preset-env": "7.16.4",
"@babel/preset-react": "7.13.13",
"@babel/traverse": "7.12.0",
"babel-plugin-rewire": "1.2.0",
"cypress": "^10.8.0",
"cypress-mochawesome-reporter": "^3.2.2",
"cypress-multi-reporters": "^1.6.1",
"junit-report-merger": "^4.0.0",
"mocha": "^10.0.0",
"mocha-junit-reporter": "^2.0.2",
"react": "17.0.2",
"react-dom": "17.0.2",
"react-is": "^18.2.0",
"react-router-dom": "6.10.0",
"react-scripts": "4.0.3",
"sonarqube-scanner": "2.8.1"
},
"jest": {
"moduleNameMapper": {
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileMock.js",
"\\.(css|less)$": "identity-obj-proxy"
}
},
"jestSonar": {
"reportPath": "test/reports",
"reportFile": "test-report.xml",
"indent": 4
}
"name": "@dod-advana/advana-platform-ui",
"version": "2.8.5",
"private": false,
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/dod-advana/advana-module-platform-ui.git"
},
"babel": {
"presets": [
"@babel/preset-react",
"@babel/preset-env"
],
"plugins": [
[
"@babel/plugin-proposal-class-properties",
{
"loose": true
}
],
[
"@babel/plugin-syntax-class-properties"
],
[
"@babel/plugin-proposal-private-methods",
{
"loose": true
}
],
[
"babel-plugin-import",
{
"libraryName": "@material-ui/core",
"libraryDirectory": "",
"camel2DashComponentName": false
},
"core"
],
[
"babel-plugin-import",
{
"libraryName": "@material-ui/icons",
"libraryDirectory": "",
"camel2DashComponentName": false
},
"icons"
]
]
},
"dependencies": {
"@babel/plugin-proposal-class-properties": "7.13.0",
"@babel/plugin-syntax-class-properties": "7.12.13",
"@datapunt/matomo-tracker-react": "0.4.0",
"@emotion/react": "11.9.3",
"@emotion/styled": "11.9.3",
"@material-ui/core": "4.11.4",
"@material-ui/icons": "4.11.2",
"axios": "1.4.0",
"babel-plugin-import": "1.13.5",
"jws": "4.0.0",
"react-slidedown": "2.4.5",
"styled-components": "5.2.3",
"underscore": "1.13.1"
},
"peerDependencies": {
"react": "17.0.2",
"react-dom": "17.0.2",
"react-router-dom": "6.10.0"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "jest --coverage --coverageDirectory=test/coverage --detectOpenHandles --passWithNoTests",
"publish:local": "npm publish --registry http://localhost:4873/",
"publish:aws": "npm publish --registry http://10.194.9.122",
"publish:prepare": "rm -rf dist && mkdir dist && babel src/lib -d dist --copy-files",
"sonarscan": "sonar-scanner"
},
"resolutions": {
"@babel/preset-env": "7.16.4",
"ansi-html": "0.0.9",
"browserslist": "4.17.3",
"glob-parent": "5.1.2",
"immer": "9.0.6",
"node-forge": "1.0.0",
"nth-check": "2.0.1",
"shell-quote": "1.7.3"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"@babel/cli": "7.13.16",
"@babel/plugin-proposal-private-methods": "7.16.11",
"@babel/preset-env": "7.16.4",
"@babel/preset-react": "7.13.13",
"@babel/traverse": "7.12.0",
"babel-plugin-rewire": "1.2.0",
"cypress": "^10.8.0",
"cypress-mochawesome-reporter": "^3.2.2",
"cypress-multi-reporters": "^1.6.1",
"junit-report-merger": "^4.0.0",
"mocha": "^10.0.0",
"mocha-junit-reporter": "^2.0.2",
"react": "17.0.2",
"react-dom": "17.0.2",
"react-is": "^18.2.0",
"react-router-dom": "6.10.0",
"react-scripts": "4.0.3",
"sonarqube-scanner": "2.8.1"
},
"jest": {
"moduleNameMapper": {
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileMock.js",
"\\.(css|less)$": "identity-obj-proxy"
}
},
"jestSonar": {
"reportPath": "test/reports",
"reportFile": "test-report.xml",
"indent": 4
}
}
54 changes: 28 additions & 26 deletions src/lib/megamenu/AdvanaMegaMenuPill.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,32 +90,34 @@ const AdvanaMegaMenuPill = (props) => {
<PersonIcon fontSize="large" />
</IconButton>
</Box>
<Box
style={{
width: "100vw",
height: menuOpen ? "100vh" : 0,
overflow: menuOpen ? "visible" : "hidden",
marginTop: 0,
color: "white",
zIndex: 1000,
position: "fixed",
transition: "left .6s",
top:
headerOffset && headerOffset !== 0
? "calc(30px + " + headerOffset + ")"
: 30,
left: menuOpen ? 0 : "100vw",
fontSize: 16,
}}
>
<AdvanaMegaMenu
showCloseButton={false}
pillMenu={true}
defaultHeader={defaultHeader}
defaultMenuOpen={menuOpen}
toggleMenu={toggleMenu}
/>
</Box>
{menuOpen && (
<Box
style={{
width: "100vw",
height: menuOpen ? "100vh" : 0,
overflow: menuOpen ? "visible" : "hidden",
marginTop: 0,
color: "white",
zIndex: 1000,
position: "fixed",
transition: "left .6s",
top:
headerOffset && headerOffset !== 0
? "calc(30px + " + headerOffset + ")"
: 30,
left: menuOpen ? 0 : "100vw",
fontSize: 16,
}}
>
<AdvanaMegaMenu
showCloseButton={false}
pillMenu={true}
defaultHeader={defaultHeader}
defaultMenuOpen={menuOpen}
toggleMenu={toggleMenu}
/>
</Box>
)}
</>
);
};
Expand Down

0 comments on commit 37e2d99

Please sign in to comment.