Blob #43
Blob #43
Conversation
|
@lovesh I don't understand why the |
|
Couple naming related changes from the spec.
|
I had started building off an older commit. Will fix this. UPDATE: Have rebased master |
lovesh
force-pushed
the
develop
branch
2 times, most recently
from
8e8ff20 to
fb09b4c
Compare
runtime/src/blob.rs
Outdated
|
|
||
| #[test] | ||
| fn add_blob() { | ||
| if !in_ext() { |
There was a problem hiding this comment.
Same comment on the extra call to the test function as one of the earlier PRs. Let's address this with one of the approaches discussed there.
runtime/src/blob.rs
Outdated
| use super::*; | ||
| use crate::test_common::*; | ||
|
|
||
| fn rando_bytes(len: usize) -> Vec<u8> { |
There was a problem hiding this comment.
Changed in 99a5659.
rando_bytes -> random_bytes
runtime/src/test_common.rs
Outdated
| pub use std::iter::once; | ||
|
|
||
| pub type RevoMod = crate::revoke::Module<Test>; | ||
| pub type BlobMod = crate::blob::Module<Test>; |
There was a problem hiding this comment.
BlobMod is not used anywhere else so it should not be added here.
There was a problem hiding this comment.
Addressed in 99a5659.
Moved BlobMod declaration into blob test module.
|
@bddap Minor suggestions, otherwise LGTM. |
Can you update the spec as well? |
|
Implements the node side of https://github.com/docknetwork/planning/blob/master/spec/0003-schema.md