adding 'json:omitempty' on optional Volume fields to avoid errors on Docker #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we had a bit the same problem. i did pull #107 but did not include all optional fields. |
|
Yes! I just saw it! That was hard to find... hehe... hope PR gets accepted...
…Sent from my iPhone
On 12 Aug 2018, at 15:13, Blomart Cédric ***@***.***> wrote:
I guess we had a bit the same problem. i did pull #107 but did not include all optional fields.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Closing as this was implemented in #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard to find docker daemon error with the CreatedAt Volume field because go-plugins-helpers was encoding it even when the field was empty.
closes #108