Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServeUnix group argument always 'docker'? #38

Open
ahmetb opened this issue Mar 10, 2016 · 4 comments
Open

ServeUnix group argument always 'docker'? #38

ahmetb opened this issue Mar 10, 2016 · 4 comments

Comments

@ahmetb
Copy link

ahmetb commented Mar 10, 2016

It appears like when we create plugin sockets the group must be either root or docker. Root worked fine for me for a while until I tried my plugin on CoreOS (it basically said root group not found, but it was there). So I switched to docker group, which I believe the right thing to do.(?)

Is there a use case where this group argument might be something other than "docker" value?

@ahmetb ahmetb closed this as completed Jun 29, 2016
@CWSpear
Copy link

CWSpear commented Nov 10, 2016

@ahmetalpbalkan why did you close this? What did you discovered? I'm running into the same issue where root doesn't work on CoreOS.

@ahmetb
Copy link
Author

ahmetb commented Nov 10, 2016

I closed due to inactivity. Reopening in case you want to follow up.

@ahmetb ahmetb reopened this Nov 10, 2016
@CWSpear
Copy link

CWSpear commented Nov 10, 2016

Yeah, indeed, I'm seeing issues with CoreOS giving an error root group not found, but it works if you use docker. docker seems to work elsewhere. I did a search on GitHub and the vast majority seem to pass root to handler.ServeUnix.

@dave-tucker
Copy link
Contributor

I'm pretty sure the gid needs to be the same as is used for docker. As for what that gid is, it will vary depending on how Docker is packaged. The most sensible option for plugin authors is to allow the gid to be user specified, but I think in most cases root seems to do the trick.

yholkamp added a commit to yholkamp/cinder-docker-driver that referenced this issue Apr 17, 2017
On CoreOS it is not possible to create the socket with the 'root' group, it has to be 'docker'. Reference: docker/go-plugins-helpers#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants