Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several issues merged in pull request. #17 and #25 #28

Closed
wants to merge 42 commits into from
Closed

Several issues merged in pull request. #17 and #25 #28

wants to merge 42 commits into from

Conversation

tomarnepedersen
Copy link
Collaborator

No description provided.

tomarnepedersen and others added 30 commits January 19, 2024 07:28
@tomarnepedersen
Working on #17. Updated to adhere to a new schema which DNV will use …
009a403 
…when testing collision and grounding avoidance systems
@tomarnepedersen
Working on #17, fixing some ruff and black warnings
d0bce34
@tomarnepedersen
Working on #17, all json input files are now following camelCasing.
107dcb9
@tomarnepedersen
Working on #17.
2026762
@tomarnepedersen
Working on #17. Fixed convert problems in the nested dict. Added a fi…
4107d30 
…eld which were missing in the schema (static.nav_status)
@tomarnepedersen
#17, updated generated traffic situation files based on new schema
1e06afa
@tomarnepedersen
Working on #17. A few problems with the conversion between camel-snak…
a98cd2b 
…e-camel case. Now tests seem to go through locally at least.
@tomarnepedersen
#17 fixed ruff error
8e5e6a6
@tomarnepedersen
Working on #17. Type targetShip changed to targetShips to reflect it …
b44941a 
…is a list of target ships. Updated generated files
@tomarnepedersen
Working #17. Removed lat_lon0 as a setting, instead always using ship…
c56fc65 
… initial position in lat lon as the reference point lat_lon0. Renamed test_08 file.
@tomarnepedersen
Working on #17. Fixed black error.
7200d3d
@tomarnepedersen
Still working on #17. Fixed tests. Updated several methods.
4fdef98
@tomarnepedersen
#17, updated tests. Believe the problem of different behaviour on loc…
e625f95 
…al and github is solved. Updated one test input file as it was wrong. Not sure what has happened there
@tomarnepedersen
#17, for some reason different behaviour for python 3.9 Rolling back …
4d10940 
…one change
@tomarnepedersen
#17, Removing MMSI number from the input target ship. Declaring the M…
6843adc 
…MSI field optional.
@tomarnepedersen
#17 Fixed some plotting problems, adjusted number of digits used for …
b49de81 
…lat lon.
@tomarnepedersen
#17 Updated documentation
379c625
@tomarnepedersen
#17 do have some problems with python 3.9 test, rolled back one addit…
234f4eb 
…ional assert.
@tomarnepedersen
#17 Fixed ship type to passenger instead of combined passenger/ro-ro
7a1b3aa
@minhemdnv
add maritime-schema
a793021
@minhemdnv
more changes for maritime-schema
3a2754e
@minhemdnv
re-run commands to generate situations
2f6b05d
@minhemdnv
remove types not used
4cd0428
@minhemdnv
fix target vessels not showing
2fa6e03
@minhemdnv
update maritime-schema to PyPI
46f1ab0
@minhemdnv
imports on a single line
8cbb831
@ClaasRostock
pyproject.toml : updated poetry dependency specifications for maritim…
c56a5e5 
…e-schema and for python
@tomarnepedersen
Working on #25. Added some information to situation input files. Chan…
3892fec 
…ges several files to solve the issue.
@tomarnepedersen
Working on #25. Tests updated. Updated several files.
16e295b
@tomarnepedersen
Still working on #25
5ece6a8
tomarnepedersen and others added 11 commits April 2, 2024 11:11
@tomarnepedersen
Working on #25. Generated files are now written in Maritime units (de…
979f984 
…g, knots)
@tomarnepedersen
Working on #25. Updated test files, fixed some problems with tests no…
0416bd6 
…t going through.
@tomarnepedersen
Working on #25. Small adjustments. Generated new traffic situation fi…
a6234ad 
…les.
@tomarnepedersen
Removing some warnings #25
bae90ea
@ClaasRostock
read_file.py : proposal for recursive function `convert_keys_to_snake…
6f90ae5 
…_case()`
@ClaasRostock
write_traffic_situation_to_file.py: merged convert_ship_data...()me…
4126bc5 
…thods into one.
@ClaasRostock
read_files.py : improved
76ea62f
@tomarnepedersen
Small changes to the implementation from Claas. Seems to work just fi…
520c05f 
…ne. #25
@tomarnepedersen
Merge pull request #26 from dnv-opensource/25-review-claas
c9749fd 
25 review claas
@tomarnepedersen
Working on #25. Updated the write_traffic_situation_to_file.py and ge…
f47d09d 
…nerated new baseline situations. Now using maritime schema 0.0.6.
@tomarnepedersen
#25 Fixed possibly unbounded variables. Pyright error.
28554da
minhemdnv
minhemdnv approved these changes Apr 10, 2024
View reviewed changes
Copy link

@minhemdnv minhemdnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested with the latest version of maritime-schema (0.06)
✅ Tested with the latest version of other tools

@tomarnepedersen
Merge pull request #28 from dnv-opensource/25-remove-the-need-for-pos…
fa36ef5 
…ition-in-north-east

Several issues merged in pull request. #17 and #25
@tomarnepedersen tomarnepedersen deleted the 25-remove-the-need-for-position-in-north-east branch April 10, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhemdnv minhemdnv minhemdnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomarnepedersen @minhemdnv @ClaasRostock