Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rqueztech #44

Merged
merged 3 commits into from
May 15, 2024
Merged

Rqueztech #44

merged 3 commits into from
May 15, 2024

Conversation

rqueztech
Copy link

@rqueztech rqueztech commented May 10, 2024

Description

Added 18 ports that were previously not accounted for in the previous struct under registered ports.

Fixes # (18)

Type of change

Please delete options that are not relevant.

  • Added Data, new ports

How Has This Been Tested?

Ran the main file to test if the new ports are being retrieved. Made sure nothing was off about how the elements were added.

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

@dnnrly
Copy link
Owner

dnnrly commented May 10, 2024

Hi, thanks so much for the contribution! There's no need to update the Readme with details of updates carried out as the Git history is sufficient for this project. If you can remove that change then I can merge the rest. 😄

Copy link
Owner

@dnnrly dnnrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be removed.

@rqueztech
Copy link
Author

Oh got it! I misread the instructions haha.

@rqueztech
Copy link
Author

Howdy howdy! Just removed that pesky vandalizing of the README file :). If there is any other issues please feel free to let me know!

@dnnrly dnnrly merged commit 88720a1 into dnnrly:master May 15, 2024
2 checks passed
@dnnrly
Copy link
Owner

dnnrly commented May 15, 2024

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants