Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor #86] 상호작용 비즈니스 로직 리팩토링 #87

Merged
merged 8 commits into from
Aug 26, 2024
Merged

[refactor #86] 상호작용 비즈니스 로직 리팩토링 #87

merged 8 commits into from
Aug 26, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Aug 25, 2024 •
edited
Loading

관련 이슈

💫 작업 요약

  • 상호작용 비즈니스 로직 리팩토링
  • 특정 조건에서 상호작용 수 증가하지 않는 문제 해결

🔍 중점적으로 리뷰 할 부분

  • interactionService
  • local에서 스웨거로 테스트하는데 추가 정보 입력 API에서 계속 401 에러가 뜹니다,,,
    배포 사이트에서는 잘 됩니다

@hyun2371 hyun2371 added the ♻️ refactor 코드 기능 유지하되 코드 변경 label Aug 25, 2024
@hyun2371 hyun2371 requested a review from dudxo August 25, 2024 09:09
@hyun2371 hyun2371 self-assigned this Aug 25, 2024
@hyun2371 hyun2371 linked an issue Aug 25, 2024 that may be closed by this pull request
♻️ 상호작용 비즈니스 로직 리팩토링 #86
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 25, 2024 •
edited
Loading

Code Coverage

Overall Project 83.89% -0.44% 🍏
Files changed 84.21% 🍏

File Coverage
InteractionCount.java 88.1% -11.9% ❌
InteractionService.java 84.38% -7.81% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 25, 2024 •
edited
Loading

Test Results

18 files  18 suites   12s ⏱️
94 tests 94 ✅ 0 💤 0 ❌
95 runs  95 ✅ 0 💤 0 ❌

Results for commit c7e6e14.

♻️ This comment has been updated with latest results.

dudxo
dudxo approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바로 리팩토링하셨네요! 수고 많으셨습니다ㅎㅎ 근데 스웨거에서는 왜 작동이 안될까요?

src/main/java/com/dnd/gongmuin/post_interaction/service/InteractionService.java Outdated Show resolved Hide resolved
@hyun2371 hyun2371 merged commit 082a887 into dev Aug 26, 2024
3 checks passed
@hyun2371 hyun2371 deleted the refactor/#86/interaction-service branch August 26, 2024 05:53
@dudxo dudxo mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudxo dudxo dudxo approved these changes

Assignees

@hyun2371 hyun2371

Labels
♻️ refactor 코드 기능 유지하되 코드 변경
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ 상호작용 비즈니스 로직 리팩토링
2 participants
@hyun2371 @dudxo