Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat #61] String-> Enum 변환 실패 시 커스텀 예외 반환 #62

Merged
merged 6 commits into from
Aug 20, 2024
Merged

[feat #61] String-> Enum 변환 실패 시 커스텀 예외 반환 #62

merged 6 commits into from
Aug 20, 2024

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • MemberErrorCode, InteractionErrorCode 추가
    • enum 변환 실패 시 에러 코드 담긴 예외 반환
  • 클래스 레벨 request mapping 삭제

@hyun2371 hyun2371 added the ✨ feat 기능 추가 label Aug 20, 2024
@hyun2371 hyun2371 requested a review from dudxo August 20, 2024 10:19
@hyun2371 hyun2371 self-assigned this Aug 20, 2024
@hyun2371 hyun2371 linked an issue Aug 20, 2024 that may be closed by this pull request
✨ String-> Enum 변환 실패 시 커스텀 예외 반환 #61
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Test Results

84 tests   84 ✅  8s ⏱️
18 suites   0 💤
18 files     0 ❌

Results for commit 053d07c.

dudxo
dudxo approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 한번 둘러보시면서 수정하신 것 같네요
수고 많으셨습니다!

src/main/java/com/dnd/gongmuin/member/domain/JobCategory.java Show resolved Hide resolved
@hyun2371 hyun2371 merged commit 51e33ea into dev Aug 20, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#61/enum-custom-validation branch August 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudxo dudxo dudxo approved these changes

Assignees

@hyun2371 hyun2371

Labels
✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ String-> Enum 변환 실패 시 커스텀 예외 반환
2 participants
@hyun2371 @dudxo