Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat #41] 나의활동 API #47
[feat #41] 나의활동 API #47
Changes from all commits
b0a5fe2
f5c0ab6
13df26b
f4da065
c20044b
0fd9dbb
68fcc48
c78b07e
a19f04d
bf0688c
0bc4f2a
0ef0198
1b00e27
b12a8f5
f3267af
083ecd7
a315d55
3139d9f
7fff790
c1ac55b
f1271bc
64df7d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 따로 변수로 빼야하나 생각이 듭니다! 변수명를을축약하니까 한 번 더 생각을 해야 하는 것 같아요! static import를 하면 별로 길어질 것 같지 않습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 가현님 코드를 참고하며 static import를 하다보니 무언가 더 이해하기 힘들다라는 생각이 들더라고요!
이 부분은 추후 더 생각해보겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQuestionPost가 static import 해서 questionPost로 되는거라 이해가 안된다는 말씀이 잘 와닿지 않네요,, 저는 오히려 개인적으로 약어를 변수명으로 선언한게 한 번 더 생각하도록 만든다고 느꼈습니다!