Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore #173] 운영 서버 / 개발 서버 분리 #174

Merged
merged 11 commits into from
Dec 17, 2024
Merged

[chore #173] 운영 서버 / 개발 서버 분리 #174

merged 11 commits into from
Dec 17, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Dec 17, 2024 •
edited
Loading

관련 이슈

📑 작업 상세 내용

  • 기존 서버는 개발 서버로 두고 운영 서버 신설
    • application.yml prod, dev 분리
    • cd_prod.yml 추가
  • 운영 환경 RDS는 private ip없이 ssh tunneling으로 연결
  • secret 변수 추가
    • postfix prod, dev로 구분

💫 작업 요약

  • 운영 서버 추가 및 기존 개발 서버 파일명 및 변수명 수정

🔍 중점적으로 리뷰 할 부분

  • notion에 추가했으니 참고하시면 됩니다~
    • application-prod.yml
    • rds tunneling으로 intellj에 연결 방법
  • swagger url list 삭제 -> 단일 접속

@hyun2371 hyun2371 self-assigned this Dec 17, 2024
@hyun2371 hyun2371 linked an issue Dec 17, 2024 that may be closed by this pull request
⚙️ 운영 서버 / 개발 서버 분리 #173
Closed
1 task
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 83.5% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Test Results

 28 files   28 suites   14s ⏱️
137 tests 135 ✅ 2 💤 0 ❌
138 runs  136 ✅ 2 💤 0 ❌

Results for commit 746eb9a.

♻️ This comment has been updated with latest results.

@hyun2371 hyun2371 added the ⚙️ chore 환경 세팅 label Dec 17, 2024
dudxo
dudxo approved these changes Dec 17, 2024
View reviewed changes
.github/workflows/cd_dev.yml
@@ -14,26 +14,22 @@ jobs:
- name: Checkout code
uses: actions/checkout@v3

# 자바 버전 설정
- name: Set up JDK 17
- name: 자바 버전 설정
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순 궁금해서 그런데, 이전 영문 네이밍에서 한글 네이밍으로 변경한 이유가 무엇인가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한글로 보는게 가독성도 좋고 주석 추가할 필요도 없는 것 같아서 변경했습니다!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

설정에 이상이 있어서 그런건 아닌거군요. 답변 감사합니다~

src/main/java/com/dnd/gongmuin/common/config/SwaggerConfig.java Outdated
@@ -14,7 +14,8 @@
description = "공무인 API 명세서",
version = "v.1.0"),
servers = {
@Server(url = "https://gongmuin.site", description = "Deploy Server URL"),
@Server(url = "https://gongmuin.site", description = "개발 서버"),
@Server(url = "https://gongmuin.shop", description = "운영 서버"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개발/운영 서버 도메인을 나눔으로써 소셜 로그인도 변경해야겠네요..!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

application.yml에 있는 redirect_uri 말씀하시는걸까요?!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml도 그렇고 Open API 페이지에서도요!
천천히 해보겠슴당

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml 내 redirct_url 수정해서 배포하고 notion에도 반영했습니다!

@hyun2371 hyun2371 merged commit d05dbc9 into dev Dec 17, 2024
3 checks passed
@hyun2371 hyun2371 deleted the chore/#173/server-division branch December 27, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudxo dudxo dudxo approved these changes

Assignees

@hyun2371 hyun2371

Labels
⚙️ chore 환경 세팅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚙️ 운영 서버 / 개발 서버 분리
2 participants
@hyun2371 @dudxo