-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor #156] 채팅 요청 목록 API에서 채팅 파트너 조회 로직 리팩토링 #157
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1cb46aa
[feat] : 채팅 요청에 createdAt 필드 추가
hyun2371 d43de77
[feat] : 채팅 요청 테스트 픽스쳐에 createdAt 추가
hyun2371 925386a
[feat] : 채팅 파트너 구하는 로직 DTO에 추가
hyun2371 3749152
[refactor] : 채팅 파트너 구하는 로직 DTO로 이동
hyun2371 70da9d6
[style] : 코드 리포멧팅
hyun2371 d890e4f
[test] : createdAt 포함된 testFixture 사용
hyun2371 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
package com.dnd.gongmuin.common.fixture; | ||
|
||
import java.time.LocalDateTime; | ||
|
||
import org.springframework.test.util.ReflectionTestUtils; | ||
|
||
import com.dnd.gongmuin.chat_inquiry.domain.ChatInquiry; | ||
|
@@ -40,6 +42,7 @@ public static ChatInquiry chatInquiry( | |
message | ||
); | ||
ReflectionTestUtils.setField(chatInquiry, "id", id); | ||
ReflectionTestUtils.setField(chatInquiry, "createdAt", LocalDateTime.now()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 테스트 수정👍 |
||
return chatInquiry; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 chatInquiry만 필요하도록 바꿔서, CaseBuilder()를 확 줄였네요!