[feat #142] 채팅 요청 API를 채팅방 API로부터 분리 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Code Coverage
|
Test Results 28 files 28 suites 14s ⏱️ Results for commit a6371c5. ♻️ This comment has been updated with latest results. |
dudxo
approved these changes
Nov 15, 2024
dudxo
reviewed
Nov 16, 2024
| private Member getChatPartner(Member member, ChatRoom chatRoom) { | ||
| if (member.isEqualMember(chatRoom.getAnswerer().getId())) { | ||
| return chatRoom.getInquirer(); | ||
| } else if (member.isEqualMember(chatRoom.getInquirer().getId())) { |
| @@ -133,6 +133,10 @@ public void updateProfile(String nickname, JobGroup jobGroup, JobCategory jobCat | |||
| this.jobCategory = jobCategory; | |||
| } | |||
|
|
|||
| public boolean isEqualMember(Long id) { | |||
There was a problem hiding this comment.
eqluas를 재정의해서 쓰는 것도 좋아보여요!
equals와 JAP 영속성 관련해서 제가 어제 포스팅 하나 했는데 한 번 읽어보시면 좋을 것 같습니다!
There was a problem hiding this comment.
넵! 다음 PR에 수정해서 반영하겠습니다~
정확히는 디렉토리를 chatroom과 chat_inquiry로 분류했습니다. 두 엔티티의 역할이 다르다고 생각해서 분리하였습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분