[feat #127] 채팅방 목록 API 페이징, 테스트 추가 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Code Coverage
|
Test Results 25 files 25 suites 14s ⏱️ Results for commit bf64cfb. ♻️ This comment has been updated with latest results. |
dudxo
approved these changes
Oct 2, 2024
| return chatRoomInfos.stream() | ||
|
|
||
| // 최신순 정렬 및 변환 | ||
| List<ChatRoomSimpleResponse> responsePage = chatRoomInfos.stream() |
There was a problem hiding this comment.
정렬 및 반환 메서드가 따로 분리되면 한층 보기 좋아질 것 같네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분