Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat #117] 회원 탈퇴 API #118

Merged
merged 24 commits into from
Nov 4, 2024
Merged

[feat #117] 회원 탈퇴 API #118

merged 24 commits into from
Nov 4, 2024

Conversation

dudxo
Copy link
Collaborator

@dudxo dudxo commented Sep 24, 2024 •
edited
Loading

관련 이슈

📑 작업 상세 내용

  • 카카오, 네이버 각 연결된 소셜 서비스 연결 끊기
  • 서비스 회원 탈퇴(SOFT DELETE) 미구현
    • 추후 논의 필요
  • 회원 탈퇴 시 기존 발급 된 AccessToken/RefreshToeken 삭제 및 블랙리스트 추가

💫 작업 요약

  • 서비스 회원탈퇴(SOFT DELETE)를 제외한 소셜 로그인 회원 탈퇴 로직 구현

🔍 중점적으로 리뷰 할 부분

  • 여러 논의를 위해서 선제 PR 올립니다..!
image - 카카오 개발 문서를 확인하면 회원 탈퇴(연결 끊기) 시 사용자 정보를 복구 불가능한 방법으로 파기해야된다고 합니다? 보관하면 안된다는데 이러면 SOFT DELETE를 하면 안되는것 같기도하네요.. - 네이버는 아직 문서를 제대로 읽어보지 않아서 잘 모르곘습니다. 추후 확인하고 남기겠습니다. - 개발 후 카카오 문서를 조금 더 읽어보니 회원 탈퇴 후 이에 대한 응답 값을 카카오 서버 측에 보내주어야 된다는데, 이에 대해 조금 더 확인해보고 진행하겠습니다.

이후 작업

  • 팀 전체 회의 간 SOFT DELETE가 아닌 HARD DELETE 방식으로 변경하기로 결정
  • HARD DELETE 방식 구현(단, 공무인의 귀중한 자산인 질문과 답변은 익명(탈퇴자) 회원으로 매핑 변경)

@dudxo dudxo added the ✨ feat 기능 추가 label Sep 24, 2024
@dudxo dudxo self-assigned this Sep 24, 2024
@dudxo dudxo linked an issue Sep 24, 2024 that may be closed by this pull request
✨ 회원 탈퇴 API #117
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Code Coverage

Overall Project 85.47% -4.64% 🍏
Files changed 60.04% ❌

File Coverage
QuestionPost.java 92.62% -3.28% ❌
Answer.java 89.19% -10.81% ❌
AuthController.java 70.49% 🍏
AuthService.java 65.99% -34.01% 🍏
MemberService.java 49.77% -20.81% ❌

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Test Results

 25 files   25 suites   14s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
127 runs  127 ✅ 0 💤 0 ❌

Results for commit 1ea0bfa.

♻️ This comment has been updated with latest results.

@dudxo dudxo requested a review from hyun2371 September 27, 2024 02:36
hyun2371
hyun2371 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! 팀회의 때 더 논의해봐요~

src/main/java/com/dnd/gongmuin/auth/dto/response/MemberDeletionResponse.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/common/config/RestTemplateConfig.java Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/member/service/MemberService.java Show resolved Hide resolved
@dudxo dudxo requested a review from hyun2371 October 22, 2024 14:16
@dudxo dudxo requested a review from hyun2371 October 24, 2024 08:58
hyun2371
hyun2371 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard delete 구현하느라 고생 많으셨습니다!

src/main/java/com/dnd/gongmuin/question_post/repository/QuestionPostRepository.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/question_post/repository/QuestionPostRepository.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/gongmuin/question_post/repository/QuestionPostRepository.java Outdated

@Modifying(flushAutomatically = true, clearAutomatically = true)
@Query("UPDATE QuestionPost q SET q.member = :anonymous WHERE q.member.id = :memberId")
public void updateQuestionPosts(Long memberId, Member anonymous);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jpa에서 제공하는 함수가 아니라 직접 정의한 함수니까 시간되실 때 해당 벌크연산에 대한 테스트를 해도 좋을 것 같네요!

@dudxo dudxo merged commit 6a980c5 into dev Nov 4, 2024
3 checks passed
@dudxo dudxo deleted the feat/#117/delete-member branch November 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun2371 hyun2371 hyun2371 approved these changes

Assignees

@dudxo dudxo

Labels
✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 회원 탈퇴 API
2 participants
@dudxo @hyun2371