[refactor] : 검증로직 함수 추출

dnd-side-project · Jan 10, 2025 · fd7b8cd · fd7b8cd
1 parent 93f24f6
commit fd7b8cd
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/main/java/com/dnd/gongmuin/question_post/service/QuestionPostService.java b/src/main/java/com/dnd/gongmuin/question_post/service/QuestionPostService.java
@@ -128,12 +128,10 @@ public UpdateQuestionPostResponse updateQuestionPost(
 	@Transactional
 	public DeleteQuestionPostResponse deleteQuestionPost(
 		Long questionPostId
-	){
+	) {
 		QuestionPost questionPost = questionPostRepository.findById(questionPostId)
 			.orElseThrow(() -> new NotFoundException(QuestionPostErrorCode.NOT_FOUND_QUESTION_POST));
-		if (answerRepository.existsByQuestionPostId(questionPostId)) {
-			throw new ValidationException(QuestionPostErrorCode.CAN_NOT_DELETE_QUESTION_POST);
-		}
+		validateIfQuestionPostExists(questionPostId);
 		refundDeletedQuestionPost(questionPost);
 		questionPostRepository.deleteById(questionPostId);
 
@@ -149,6 +147,12 @@ private void updateQuestionPostImages(QuestionPost questionPost, List<String> im
 		}
 	}
 
+	private void validateIfQuestionPostExists(Long questionPostId) {
+		if (answerRepository.existsByQuestionPostId(questionPostId)) {
+			throw new ValidationException(QuestionPostErrorCode.CAN_NOT_DELETE_QUESTION_POST);
+		}
+	}
+
 	private void deleteImages(QuestionPost questionPost) {
 		questionPostImageRepository.deleteByQuestionPost(questionPost);
 		questionPost.clearPostImages();
@@ -188,7 +192,7 @@ private void refundClosedQuestionPosts() {
 		});
 	}
 
-	private void saveRefundCreditHistory(Member member, int reward){
+	private void saveRefundCreditHistory(Member member, int reward) {
 		memberRepository.save(member);
 
 		creditHistoryService.saveCreditHistory(