check gfal-copy exit status first. Fix #5310 (#5311)

dmwm · May 13, 2024 · 8383629 · 8383629
1 parent d4b4151
commit 8383629
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/python/CRABClient/Commands/remote_copy.py b/src/python/CRABClient/Commands/remote_copy.py
@@ -296,12 +296,13 @@ def processWorker(self, input_, successfiles, failedfiles):
 
             logger.debug("Finish executing for file %s" % fileid)
 
-            if returncode != 0 or len(error) > 0:
+            if returncode != 0:
                 logger.info("%sWarning%s: Failed retrieving %s" % (colors.RED, colors.NORMAL, fileid))
                 #logger.debug(colors.RED +"Stderr: %s " %stderr+ colors.NORMAL)
-                for x in error:
-                    logger.info(colors.RED +"\t %s" % x + colors.NORMAL)
-                failedfiles[fileid] = str(error)
+                if len(error) > 0:
+                    for x in error:
+                        logger.info(colors.RED +"\t %s" % x + colors.NORMAL)
+                    failedfiles[fileid] = str(error)
                 logger.debug("Full stderr follows:\n%s" % stderr)
 
                 if "timed out" in stderr or "timed out" in stdout: