Get back e2e binary tests

dmtrKovalenko · Aug 25, 2024 · c090038 · c090038
1 parent ce1df85
commit c090038
Show file tree

Hide file tree

Showing 6 changed files with 5,134 additions and 72 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -75,3 +75,20 @@ jobs:
       - run: opam exec -- dune build --verbose
       - run: opam exec -- dune exec ODiffBin -- --version 
 
+      - uses: pnpm/action-setup@v4
+        with:
+          version: 9
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+          cache-dependency-path: 'package-lock.json'
+
+      - name: Install node deps
+        run: npm ci
+
+      - name: e2e test
+        run: pnpm test
+
diff --git a/bin/node-bindings/odiff.js b/bin/node-bindings/odiff.js
@@ -110,6 +110,8 @@ function parsePixelDiffStdout(stdout) {
 const CMD_BIN_HELPER_MSG =
   "Usage: odiff [OPTION]... [BASE] [COMPARING] [DIFF]\nTry `odiff --help' for more information.\n";
 
+const NO_FILE_ODIFF_ERROR_REGEX = /no\s+'([^']+)'\s+file\s+or\s+directory/;
+
 async function compare(basePath, comparePath, diffOutput, options = {}) {
   return new Promise((resolve, reject) => {
     let producedStdout, producedStdError;
@@ -148,7 +150,7 @@ async function compare(basePath, comparePath, diffOutput, options = {}) {
           ).replace(CMD_BIN_HELPER_MSG, "");
 
           const noFileOrDirectoryMatches = originalErrorMessage.match(
-            /no\n\s*`(.*)'\sfile or\n\s*directory/
+            NO_FILE_ODIFF_ERROR_REGEX
           );
 
           if (options.noFailOnFsErrors && noFileOrDirectoryMatches?.[1]) {